Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Table footer #1146

Closed
wants to merge 2 commits into from
Closed

feat: add Table footer #1146

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c2367d3
feat: add Table footer
krozhkov Nov 20, 2023
3dc7bb5
Merge branch 'main' into yarozhkov/feat-table-add-footer
krozhkov Dec 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/components/Table/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ Additional functionality is enabled via HOCs:
| emptyMessage | The message returned if data is missing. | `string` | `"No data"` |
| className | Table CSS class | `string` | |
| edgePadding | Adds horizontal padding for edge cells | `boolean` | |
| renderFooter | Display footer inside the table container | `() => React.ReactNode` | |

### TableColumnConfig

Expand Down
9 changes: 9 additions & 0 deletions src/components/Table/Table.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,8 @@ export interface TableProps<I> extends QAProps {
className?: string;
/** Adds horizontal padding for edge cells. */
edgePadding?: boolean;
/** Display footer inside the table container */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update README as well

renderFooter?: () => React.ReactNode;
}

interface TableDefaultProps {
Expand Down Expand Up @@ -332,6 +334,7 @@ export class Table<I extends TableDataItem = Record<string, string>> extends Rea
) : (
this.renderTable()
)}
{this.renderFooter()}
</div>
);
}
Expand Down Expand Up @@ -383,6 +386,12 @@ export class Table<I extends TableDataItem = Record<string, string>> extends Rea
);
}

private renderFooter() {
const {renderFooter} = this.props;

return renderFooter?.();
}

private renderTable() {
return (
<table ref={this.tableRef} className={b('table')}>
Expand Down
Loading