feat!: merge old Tooltip with ActionTooltip and introduce new Tooltip #1189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview is ready. |
|
Playwright Test Component is ready. |
|
Hello, I looked at why the playwright tests were failing, in another application they wrote export incorrectly |
amje
requested changes
Dec 18, 2023
Comment on lines
8
to
9
| --g-popup-border-width: 0; | ||
| --g-popup-background-color: var(--g-color-base-float-heavy); |
There was a problem hiding this comment.
No need to increase specifity here anymore
DenisVershkov
force-pushed
the
feat/introduce-new-Tooltip-component
branch
from
e395ca2 to
9066ccc
Compare
amje
requested changes
Dec 21, 2023
| qa={qa} | ||
| > | ||
| <div className={b('content', contentClassName)}> | ||
| <React.Fragment> |
There was a problem hiding this comment.
Fragment is not necessary here
| --g-popup-border-width: 0; | ||
| --g-popup-background-color: var(--g-color-base-float-heavy); | ||
|
|
||
| &__popup-content { |
There was a problem hiding this comment.
Seems this class is not exists anymore
src/components/Tooltip/Tooltip.scss
Outdated
| animation-timing-function: unset; | ||
| animation-fill-mode: unset; | ||
| } | ||
| } | ||
|
|
||
| &__popup-content { |
amje
changed the title
amje
changed the title
amje
approved these changes
Dec 22, 2023
amje
pushed a commit
that referenced
this pull request
Feb 1, 2024
amje
pushed a commit
that referenced
this pull request
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.