fix(Label): missing text overflow #1206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Playwright Test Component is ready. |
|
Preview is ready. |
amje
requested changes
Dec 27, 2023
src/components/Label/Label.scss
Outdated
Comment on lines
59
to
67
| &__content, | ||
| &__key, | ||
| &__separator, | ||
| &__value { | ||
| vertical-align: top; | ||
|
|
||
| display: inline-block; | ||
| } | ||
|
|
There was a problem hiding this comment.
It does nothing, all these elements are flex's children. Can be removed without any difference
There was a problem hiding this comment.
You're right, I guess it came from my first attempts to fix this the other way so I assumed it did something important
Vladeeg
force-pushed
the
fix/label-text-overflow
branch
from
c479d7a to
5922401
Compare
amje
approved these changes
Jan 15, 2024
goshander
approved these changes
Jan 24, 2024
Vladeeg
force-pushed
the
fix/label-text-overflow
branch
from
5922401 to
9106860
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.