Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Pagination): fix wrong behaviour in case of 0 total #1208

Merged
merged 1 commit into from
Dec 19, 2023
Merged

fix(Pagination): fix wrong behaviour in case of 0 total #1208

merged 1 commit into from
Dec 19, 2023

Conversation

maeshchenko
Copy link
Contributor

Closes #1205

@gravity-ui-bot
Copy link
Contributor

Preview is ready.

@jhoncool
Copy link
Contributor

jhoncool commented Dec 19, 2023 •
edited
Loading

Hello @maeshchenko. Thank you for the PR.
It used to work with total = 0 like total is undefined. If you want to change current behaviour so I think the PaginationInput can't change page when total is 0.

And I don't think that #1205 is a problem

@maeshchenko maeshchenko mentioned this pull request Dec 19, 2023
Closed
@jhoncool jhoncool merged commit cda2349 into gravity-ui:main Dec 19, 2023
3 of 4 checks passed
@gravity-ui-bot gravity-ui-bot mentioned this pull request Dec 19, 2023
Merged
DenisVershkov pushed a commit that referenced this pull request Dec 25, 2023
@maeshchenko @DenisVershkov
fix(Pagination): fix wrong behaviour in case of 0 total (#1208)
4c9cb41
@gravity-ui-bot gravity-ui-bot mentioned this pull request Feb 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhoncool jhoncool jhoncool approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: uikit/pagination component. При total = 0 неверное поведение компонента
3 participants
@maeshchenko @gravity-ui-bot @jhoncool