feat(Dialog): add prop contentOverflow to control overflow behaviour
#1211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DenisVershkov
requested review from
amje,
ValeraS and
korvin89
as code owners
|
Playwright Test Component is ready. |
|
Preview is ready. |
|
[DATAUI-1254] |
|
Could u provide some description? |
|
amje
requested changes
Dec 22, 2023
DenisVershkov
force-pushed
the
feature/add-scroll-to-dialog-body
branch
from
278bfe8 to
dcc130b
Compare
DenisVershkov
requested review from
resure,
ogonkov,
IsaevAlexandr,
sofiushko,
zamkovskaya,
SeqviriouM,
mournfulCoroner,
DaffPunks,
Lunory and
kseniya57
as code owners
amje
removed request for
kseniya57,
jhoncool,
NikitaCG,
LakeVostok,
goshander and
axtk
Co-authored-by: Evgeny Alaev <[email protected]>
Co-authored-by: Evgenij Shangin <[email protected]>
amje
requested changes
Jan 16, 2024
src/components/Modal/Modal.tsx
Outdated
Comment on lines
134
to
135
| <div className={b('content-aligner-wrapper')}> | ||
| <div className={b('content-container')}> |
There was a problem hiding this comment.
Let's call them content-aligner and content-wrapper
| } | ||
|
|
||
| export function DialogBody(props: DialogBodyProps) { | ||
| const {className} = props; | ||
| const {className, withDividers = false} = props; |
There was a problem hiding this comment.
We use has* naming throughout the codebase (i.e. hasClear, hasClose, hasArrow)
src/components/Dialog/Dialog.scss
Outdated
|
|
||
| &_with-scroll { | ||
| overflow-y: auto; | ||
| max-height: calc(100vh - var(--yc-modal-margin) * 2); |
There was a problem hiding this comment.
Let's use SCSS var instead, this var will be removed in v6
…eight content inside Modal
…fix; fixed animation
DenisVershkov
force-pushed
the
feature/add-scroll-to-dialog-body
branch
from
0e2574a to
3fe9fd3
Compare
|
in order not deal with merge conflicts, i created a new one #1251 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.