Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(Progress): replaced class components by functional components #1214

Merged
merged 1 commit into from
Jan 19, 2024
Merged

refactor(Progress): replaced class components by functional components #1214

merged 1 commit into from
Jan 19, 2024

Conversation

atroynikov
Copy link
Contributor

@atroynikov atroynikov commented Dec 20, 2023 •
edited
Loading

  • splited to multiple simple components
  • added React.forwardRef

@atroynikov atroynikov requested a review from Lunory as a code owner December 20, 2023 13:29
@gravity-ui-bot
Copy link
Contributor

Playwright Test Component is ready.

@gravity-ui-bot
Copy link
Contributor

Preview is ready.

@atroynikov atroynikov self-assigned this Dec 20, 2023
Lunory
Lunory reviewed Dec 22, 2023
View reviewed changes
src/components/Progress/index.ts Outdated Show resolved Hide resolved
src/components/Progress/ProgressInnerText.tsx Outdated Show resolved Hide resolved
src/components/Progress/ProgressInnerText.tsx Outdated Show resolved Hide resolved
src/components/Progress/ProgressStackItem.tsx Show resolved Hide resolved
src/components/Progress/ProgressStackItem.tsx Show resolved Hide resolved
src/components/Progress/ProgressWithValue.tsx Show resolved Hide resolved
@Lunory
Copy link
Contributor

Lunory commented Dec 25, 2023

Thanks, now that's OK

Finally, can you change Progress README? Add info aboutref and remove loading prop default value

@atroynikov
Copy link
Contributor Author

Thanks, now that's OK

Finally, can you change Progress README? Add info aboutref and remove loading prop default value

I returned initialisation for all default values from docs. There is no info about ref property in other components.

@atroynikov atroynikov force-pushed the progress-fc branch 2 times, most recently from 860cd82 to 661987a Compare January 19, 2024 09:13
@atroynikov atroynikov merged commit c9fc5c2 into next Jan 19, 2024
4 checks passed
@atroynikov atroynikov deleted the progress-fc branch January 19, 2024 10:38
amje pushed a commit that referenced this pull request Feb 1, 2024
@atroynikov @amje
refactor(Progress): replaced class components by functional components (
5c3f1c9 
#1214)
amje pushed a commit that referenced this pull request Feb 6, 2024
@atroynikov @amje
refactor(Progress): replaced class components by functional components (
cda8eb6 
#1214)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lunory Lunory Lunory approved these changes

Assignees

@atroynikov atroynikov

Labels
component: Progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@atroynikov @gravity-ui-bot @Lunory