Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(CopyToClipboard): replaced class component by functional component #1216

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

atroynikov
Copy link
Contributor

No description provided.

@gravity-ui-bot
Copy link
Contributor

Playwright Test Component is ready.

@gravity-ui-bot
Copy link
Contributor

Preview is ready.

Copy link
Contributor

@Raubzeug Raubzeug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to add Stories and tests for component in this PR?

src/components/CopyToClipboard/CopyToClipboard.tsx Outdated Show resolved Hide resolved
src/components/CopyToClipboard/CopyToClipboard.tsx Outdated Show resolved Hide resolved
@atroynikov atroynikov force-pushed the copy-fc branch 2 times, most recently from c248c22 to f85d97e Compare December 22, 2023 13:35
@atroynikov atroynikov force-pushed the copy-fc branch 4 times, most recently from 0ac6209 to 79f4bce Compare January 19, 2024 14:16
@atroynikov
Copy link
Contributor Author

Is it possible to add Stories and tests for component in this PR?

This component is wrapper for external lib and don't has own UI.
Added simple test for checking exception.

@atroynikov atroynikov merged commit 37d5836 into next Jan 23, 2024
4 checks passed
@atroynikov atroynikov deleted the copy-fc branch January 23, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants