Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert #831 #1244

Merged
merged 1 commit into from
Jan 15, 2024
Merged

fix: revert #831 #1244

merged 1 commit into from
Jan 15, 2024

Conversation

amje
Copy link
Contributor

@amje amje commented Jan 15, 2024

This change was breaking. Colgroup doesn't take into account box-sizing property. We use content-box, but colgroup sets the width for the entire column, not only the content.

@amje amje requested review from ValeraS and korvin89 as code owners January 15, 2024 11:37
@amje amje requested review from ogonkov and Raubzeug January 15, 2024 11:37
@gravity-ui-bot
Copy link
Contributor

Playwright Test Component is ready.

@gravity-ui-bot
Copy link
Contributor

Preview is ready.

Copy link
Contributor

@ogonkov ogonkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add motivation for revert please

Copy link
Contributor

@ogonkov ogonkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix in docs, that we change content with, not the whole column width

Copy link
Contributor

@ogonkov ogonkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed to change docs in separate PR

@amje amje merged commit 79f7e07 into main Jan 15, 2024
4 checks passed
@amje amje deleted the revert-table-colgroup branch January 15, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants