Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(a11y): allow ul role override #1285

Closed
wants to merge 2 commits into from
Closed

chore(a11y): allow ul role override #1285

wants to merge 2 commits into from

Conversation

ogonkov
Copy link
Contributor

@ogonkov ogonkov commented Jan 29, 2024

No description provided.

@gravity-ui-bot
Copy link
Contributor

Preview is ready.

@gravity-ui-bot
Copy link
Contributor

Playwright Test Component is ready.

@amje
Copy link
Contributor

amje commented Jan 30, 2024

@ogonkov What is the story behind this change? No code changed, only the rule

@ogonkov
Copy link
Contributor Author

ogonkov commented Jan 30, 2024

@amje i added this rule in my other PR, decided to split it as separate PR

@ogonkov
Copy link
Contributor Author

ogonkov commented Jan 30, 2024

We decide that without comment near role=list this attribute could be removed, so it is better to use inline ignore instead

@ogonkov ogonkov closed this Jan 30, 2024
@ogonkov ogonkov deleted the chore/a11y/roles_override branch January 30, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amje amje Awaiting requested review from amje amje is a code owner

@ValeraS ValeraS Awaiting requested review from ValeraS ValeraS is a code owner

@korvin89 korvin89 Awaiting requested review from korvin89 korvin89 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ogonkov @gravity-ui-bot @amje