Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

renderPopup for Select #1312

Merged
merged 6 commits into from
Feb 7, 2024
Merged

renderPopup for Select #1312

merged 6 commits into from
Feb 7, 2024

Conversation

GermanVor
Copy link
Contributor

No description provided.

@gravity-ui-bot
Copy link
Contributor

Playwright Test Component is ready.

@gravity-ui-bot
Copy link
Contributor

Preview is ready.

@GermanVor GermanVor force-pushed the select-popup-customization branch from b2b61ef to 1230bd4 Compare February 6, 2024 17:36
@GermanVor GermanVor force-pushed the select-popup-customization branch from 1230bd4 to 04fefbc Compare February 6, 2024 19:44
@GermanVor
Copy link
Contributor Author

@korvin89
Added tests and README description

return (
<React.Fragment>
{renderFilter()}
<div className="CustomElement" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could u add some styles for this div? For example width, height and color, so that it can be seen in sandbox example

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -22,6 +22,8 @@ const style = {
padding: '4px 4px 0',
};

export const SELECT_FILTER_QA = 'SELECT_FILTER_QA';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could u add this qa here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GermanVor GermanVor changed the title [WIP] renderPopup for Select renderPopup for Select Feb 7, 2024
@GermanVor GermanVor merged commit 70f6ba8 into main Feb 7, 2024
4 checks passed
@GermanVor GermanVor deleted the select-popup-customization branch February 7, 2024 15:14
GermanVor added a commit that referenced this pull request Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants