feat: improve focus outline styles for text/select inputs #1318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kyzyl-ool
force-pushed
the
feat/outline-for-text-input-and-select
branch
from
c0782b6 to
95eb0ff
Compare
|
Playwright Test Component is ready. |
|
Preview is ready. |
amje
requested changes
Feb 7, 2024
|
@Kyzyl-ool Currently I see no difference, is it a bug or there is no default? |
I left outline color empty by default, so yes – there shouldn't be any differences. Outline on focus for inputs and selects are debatable |
Kyzyl-ool
force-pushed
the
feat/outline-for-text-input-and-select
branch
from
95eb0ff to
48b1bdf
Compare
Kyzyl-ool
added
the
a11y
|
@Kyzyl-ool Maybe we keep default offset to avoid overlapping with border? Error state not visible at all |
amje
requested changes
Mar 12, 2024
| @@ -168,6 +168,7 @@ $blockButton: '.#{variables.$ns}select-control__button'; | |||
|
|
|||
| &_error::before { | |||
| border-color: var(--g-color-line-danger); | |||
| --g-select-focus-outline-color: var(--g-color-line-danger); | |||
There was a problem hiding this comment.
This wont allow override this variable, we must use private/public pair here
| @@ -187,6 +189,10 @@ $block: '.#{variables.$ns}text-area'; | |||
| &:focus-within { | |||
| border-color: var(--g-color-line-danger); | |||
| } | |||
|
|
|||
| &:focus-within { | |||
| --g-text-area-focus-outline-color: var(--g-color-line-danger); | |||
| @@ -380,6 +382,10 @@ $block: '.#{variables.$ns}text-input'; | |||
| &:focus-within { | |||
| border-color: var(--g-color-line-danger); | |||
| } | |||
|
|
|||
| &:focus-within { | |||
| --g-text-input-focus-outline-color: var(--g-color-line-danger); | |||
amje
changed the title
amje
approved these changes
Mar 21, 2024
Comment on lines
202
to
208
| &:focus::before { | ||
| outline: 2px solid var(--g-select-focus-outline-color, var(--_--focus-outline-color)); | ||
| outline-offset: -1px; | ||
| } | ||
| &:focus:not(:focus-visible)::before { | ||
| outline: 0; | ||
| } |
There was a problem hiding this comment.
We can now safely use raw :focus-visible selector
Kyzyl-ool
force-pushed
the
feat/outline-for-text-input-and-select
branch
from
ce7e897 to
1aab151
Compare
added 7 commits
March 21, 2024 15:02
Kyzyl-ool
force-pushed
the
feat/outline-for-text-input-and-select
branch
from
1aab151 to
c566f26
Compare
korvin89
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1043