Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: a11y addon in storybook #1351

Merged
merged 42 commits into from
Mar 25, 2024
Merged

ci: a11y addon in storybook #1351

merged 42 commits into from
Mar 25, 2024

Conversation

Kyzyl-ool
Copy link
Contributor

@Kyzyl-ool Kyzyl-ool commented Feb 15, 2024 •
edited
Loading

Closes #1327

@Kyzyl-ool Kyzyl-ool marked this pull request as draft February 15, 2024 11:36
@gravity-ui-bot
Copy link
Contributor

Playwright Test Component is ready.

@gravity-ui-bot
Copy link
Contributor

Preview is ready.

@Kyzyl-ool Kyzyl-ool marked this pull request as ready for review February 15, 2024 12:48
@Kyzyl-ool Kyzyl-ool added infra CI, storybook, etc. a11y Issue or pull request related to accessibility improvements labels Feb 26, 2024
@Kyzyl-ool Kyzyl-ool force-pushed the feat/a11y-storybook-addon branch 2 times, most recently from b18666e to 7759f5e Compare March 4, 2024 09:42
amje
amje requested changes Mar 4, 2024
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
src/components/Avatar/__stories__/Avatar.stories.tsx Outdated Show resolved Hide resolved
src/components/Avatar/__stories__/Avatar.stories.tsx Outdated Show resolved Hide resolved
src/components/Slider/types.ts Outdated Show resolved Hide resolved
src/components/User/User.tsx Outdated
Comment on lines 24 to 26
alt,
avatarAriaLabel,
avatarAriaLabelledBy,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can use avatar prop, no need in these props

src/components/User/types.ts Outdated Show resolved Hide resolved
src/components/UserLabel/UserLabel.tsx Show resolved Hide resolved
src/demo/colors/ColorPanel.tsx Outdated Show resolved Hide resolved
@Kyzyl-ool Kyzyl-ool requested a review from ogonkov as a code owner March 5, 2024 13:06
@Kyzyl-ool Kyzyl-ool requested a review from amje March 5, 2024 14:37
@Kyzyl-ool Kyzyl-ool force-pushed the feat/a11y-storybook-addon branch from 75dbc1a to 5995014 Compare March 8, 2024 12:25
@Kyzyl-ool Kyzyl-ool requested a review from Arucard89 as a code owner March 8, 2024 12:25
amje
amje requested changes Mar 12, 2024
View reviewed changes
.github/workflows/playwright.yml Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
src/components/User/types.ts Outdated Show resolved Hide resolved
@Kyzyl-ool Kyzyl-ool force-pushed the feat/a11y-storybook-addon branch from 753911d to ea7449b Compare March 13, 2024 14:21
Kezhik Kyzyl-ool added 23 commits March 21, 2024 15:09
fix: adding playwright install
ce425b2
fix: focus for error text
fd2e279
fix: some minor fixes
350967c
fix: slider a11y checks
62b1e30
fix: table and tree select a11y
fe9c432
fix: showcase labels
8c4922e
fix: using double quotes in jsx syntax
4f35d0f
fix: remove redundant props for user component
4e710bf
fix: use aria-labelledby
8e4384c
fix: using ready preview for sb tests
e642aef
fix: remove unused packages
31619ff
fix: change workflow
2362ce5
fix: add checkout
9268e3a
fix: wait on job
1b1c646
fix: another job
24a9278
fix: playwright tests are waiting for preview deployed
1901f72
fix: return to the old naming
3df6588
fix: revert
c180006
fix: revert alt prop for user component
fefd322
fix: treelist fix a11y
93d16fb
fix: treelist a11y fixes
84ac0c1
fix: fixing review issues
0ff4cb0
fix: rename file
0f94500
@Kyzyl-ool Kyzyl-ool force-pushed the feat/a11y-storybook-addon branch from ef6627e to 0f94500 Compare March 21, 2024 14:11
@Kyzyl-ool Kyzyl-ool requested a review from amje March 21, 2024 14:13
@amje amje merged commit 2f0e83e into main Mar 25, 2024
4 checks passed
@amje amje deleted the feat/a11y-storybook-addon branch March 25, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amje amje amje approved these changes

@korvin89 korvin89 Awaiting requested review from korvin89 korvin89 is a code owner

@IsaevAlexandr IsaevAlexandr Awaiting requested review from IsaevAlexandr IsaevAlexandr is a code owner

@sofiushko sofiushko Awaiting requested review from sofiushko sofiushko is a code owner

@Raubzeug Raubzeug Awaiting requested review from Raubzeug Raubzeug is a code owner

@zamkovskaya zamkovskaya Awaiting requested review from zamkovskaya zamkovskaya is a code owner

@DakEnviy DakEnviy Awaiting requested review from DakEnviy DakEnviy is a code owner

@Lunory Lunory Awaiting requested review from Lunory Lunory is a code owner

@kseniya57 kseniya57 Awaiting requested review from kseniya57 kseniya57 is a code owner

@jhoncool jhoncool Awaiting requested review from jhoncool jhoncool is a code owner

@NikitaCG NikitaCG Awaiting requested review from NikitaCG NikitaCG is a code owner

@LakeVostok LakeVostok Awaiting requested review from LakeVostok

@goshander goshander Awaiting requested review from goshander goshander is a code owner

@axtk axtk Awaiting requested review from axtk axtk is a code owner

@ValeraS ValeraS Awaiting requested review from ValeraS ValeraS is a code owner

@ogonkov ogonkov Awaiting requested review from ogonkov ogonkov is a code owner

@Arucard89 Arucard89 Awaiting requested review from Arucard89 Arucard89 is a code owner

Assignees
No one assigned
Labels
a11y Issue or pull request related to accessibility improvements infra CI, storybook, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Integrate A11Y checks addon to storybook
3 participants
@Kyzyl-ool @gravity-ui-bot @amje