feat(Select): add selected elements counter on multiple selection #1368
Conversation
|
Playwright Test Component is ready. |
|
Preview is ready. |
Arucard89
changed the title
src/components/Select/components/SelectControl/SelectControl.tsx
Outdated
Show resolved
Hide resolved
| @@ -148,4 +157,13 @@ export type SelectClearProps = SelectClearIconProps & { | |||
| onMouseLeave: (e: React.MouseEvent) => void; | |||
| }; | |||
|
|
|||
| export type SelectCounterProps = { | |||
| /** number of selected elements to show */ | |||
| count: number; | |||
There was a problem hiding this comment.
I suppose it could also be a string
There was a problem hiding this comment.
We use and manage this value only inside our code, so it could be only number in this usage.
There was a problem hiding this comment.
I suppose we use it here https://github.com/gravity-ui/uikit/pull/1368/files#diff-c1510619d5ba5e80032efb9ba67b29e63307d6a80b81fc2cd3edc466a05d0439R57 as a public interface?
There was a problem hiding this comment.
Yes we pass this parameter to render props. Ok, let's make it string if it is more convenient)
fb78910
There was a problem hiding this comment.
No, I suggest to use type string | number to have opportunity to set values 1, 1k an so on
There was a problem hiding this comment.
Ok, remade it) d7ed58c
There was a problem hiding this comment.
return number) 00f69d6
Based on DATAUI-2111