Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Popup): add transition callbacks #1388

Merged
merged 4 commits into from
Mar 4, 2024
Merged

Conversation

flops
Copy link
Contributor

@flops flops commented Mar 1, 2024

Issue: #1354

@flops flops requested a review from amje as a code owner March 1, 2024 12:22
@gravity-ui-bot
Copy link
Contributor

Preview is ready.

@gravity-ui-bot
Copy link
Contributor

Playwright Test Component is ready.

@@ -20,34 +20,62 @@ import './Popup.scss';
export type PopupPlacement = PopperPlacement;
export type PopupAnchorRef = PopperAnchorRef;

type VoidFunction = () => void;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is already VoidFunction type provided by TypeScript

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@flops flops requested a review from amje March 1, 2024 14:28
@flops flops merged commit 089beac into main Mar 4, 2024
4 checks passed
@flops flops deleted the popup-transition-callbacks branch March 4, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants