feat(TreeList): new useList family component #1417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Playwright Test Component is ready. |
|
Preview is ready. |
IsaevAlexandr
commented
Mar 11, 2024
amje
requested changes
Mar 15, 2024
src/components/TreeList/TreeList.tsx
Outdated
Comment on lines
32
to
33
| renderItem: propsRenderItem, | ||
| renderContainer = TreeListContainer, |
There was a problem hiding this comment.
Suggestion: rename renderContainer to containerSlot and move renderItem to the children
There was a problem hiding this comment.
these are two different possibilities. For most tasks, you don't need to redefine the container
...omponents/TreeList/__stories__/components/WithGroupSelectionControlledStateAndCustomIcon.tsx
Outdated
Show resolved
Hide resolved
IsaevAlexandr
force-pushed
the
feat-tree-list-component
branch
from
b636f1c to
a04fe77
Compare
|
/fixed |
…e with keyboard dnd
IsaevAlexandr
force-pushed
the
feat-tree-list-component
branch
from
a04fe77 to
d6ebede
Compare
amje
requested changes
Mar 18, 2024
| /** | ||
| * Add active styles and change selection behavior during dnd is performing | ||
| */ | ||
| isDragging?: boolean; |
There was a problem hiding this comment.
Let's call dragging like other states with no is*
amje
approved these changes
Mar 18, 2024
amje
approved these changes
Mar 18, 2024
Raubzeug
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
onItemClickcallback arguments;