feat(Breadcrumbs): new component #1497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview is ready. |
|
Playwright Test Component is ready. |
ValeraS
force-pushed
the
feat/breadcrumbs
branch
from
7527556 to
f7064c7
Compare
korvin89
reviewed
May 15, 2024
| @@ -63,3 +63,32 @@ export interface ControlGroupProps<ValueType extends string = string> { | |||
| 'aria-label'?: string; | |||
| 'aria-labelledby'?: string; | |||
| } | |||
|
|
|||
| export type Key = string | number; | |||
There was a problem hiding this comment.
It should be a public type, maybe we should named it a little bit unique?
| endItems--; | ||
| } | ||
| const hiddenItems = breadcrumbs.slice(0, -endItems); | ||
| const menuItem = ( |
There was a problem hiding this comment.
Could u move it to separate component? Looks pretty abstract
ValeraS
force-pushed
the
feat/breadcrumbs
branch
from
f7064c7 to
e0f3d27
Compare
|
Visual Tests Report is ready. |
ValeraS
force-pushed
the
feat/breadcrumbs
branch
from
e0f3d27 to
ea9a3e1
Compare
korvin89
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.