feat(Select,List): graceful replacement list item view of the List #1540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview is ready. |
|
Playwright Test Component is ready. |
IsaevAlexandr
force-pushed
the
replace-list-item-view
branch
from
b15fd59 to
ee7dcfb
Compare
amje
requested changes
Jun 3, 2024
| @@ -53,7 +63,13 @@ export type ListItemProps<T> = { | |||
| itemIndex: number; | |||
| active: boolean; | |||
| selected: boolean; | |||
| // TODO: написать soft миграцию | |||
| newListView?: boolean; | |||
| @@ -26,6 +27,8 @@ type SelectListProps = { | |||
| virtualized?: boolean; | |||
| loading?: boolean; | |||
| onLoadMore?: () => void; | |||
| // TODO: надпись про soft миграцию | |||
| @@ -6,4 +6,25 @@ $block: '.#{variables.$ns}select-popup'; | |||
| display: flex; | |||
| flex-direction: column; | |||
| max-height: 90vh; | |||
|
|
|||
| &_newListView { | |||
|
|
||
| &_size_xl { | ||
| border-radius: var(--g-list-container-border-radius, 10px); | ||
| } |
There was a problem hiding this comment.
Can be shorten to:
border-radius: var(--g-list-container-border-radius, --_--border-radius);
&_size_s {
--_--border-radius: 5px;
}
// &_size_m| @@ -85,6 +85,8 @@ export type SelectProps<T = any> = QAProps & | |||
| width?: 'auto' | 'max' | number; | |||
| popupWidth?: 'fit' | number; | |||
| virtualizationThreshold?: number; | |||
| // TODO: про soft миграцию | |||
| @@ -29,6 +29,7 @@ export interface ThemeProviderProps extends React.PropsWithChildren<{}> { | |||
| scoped?: boolean; | |||
| rootClassName?: string; | |||
| layout?: Omit<PrivateLayoutProviderProps, 'children'>; | |||
| experiments?: {_newListView?: boolean}; | |||
There was a problem hiding this comment.
Why prefix names with underscore? If experiments not prefixed neither should keys inside it
| @@ -8,4 +8,8 @@ export interface ThemeContextProps { | |||
| theme: Theme; | |||
| themeValue: RealTheme; | |||
| direction: Direction; | |||
| /** | |||
| * Ability to define soft migration for new list item view | |||
There was a problem hiding this comment.
Let's clarify that the property is not for public usage
Suggested change
| * Ability to define soft migration for new list item view | |
| * DO NOT USE. Internally used for soft migration to the new list item view |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.