feat(PinInput): form support #1686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview is ready. |
|
Visual Tests Report is ready. |
korvin89
approved these changes
Jul 2, 2024
amje
reviewed
Jul 2, 2024
src/components/types.ts
Outdated
| @@ -90,3 +90,10 @@ export interface AriaLabelingProps { | |||
| */ | |||
| 'aria-details'?: string; | |||
| } | |||
|
|
|||
| export interface FocusEvents<Target = Element> { | |||
There was a problem hiding this comment.
Suggested change
| export interface FocusEvents<Target = Element> { | |
| export interface FocusEventHandlers<Target = Element> { |
There was a problem hiding this comment.
But these are events, and handlers are callbacks that you pass to those events.
There was a problem hiding this comment.
event is an argument of those handler, see how React named those callbacks: https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/react/index.d.ts#L2348
amje
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.