fix(ListItemView): div -> li default list item html tag #1698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview is ready. |
|
Visual Tests Report is ready. |
korvin89
approved these changes
Jul 9, 2024
ogonkov
reviewed
Jul 9, 2024
| @@ -98,6 +98,7 @@ export const ListWithDnd = ({size, itemsCount, 'aria-label': ariaLabel}: ListWit | |||
| dragging={snapshot.isDragging} | |||
| ref={provided.innerRef} | |||
| endSlot={<Icon data={Grip} size={16} />} | |||
| role="option" | |||
There was a problem hiding this comment.
Roles different from recommended practices, see link in issue
IsaevAlexandr
force-pushed
the
fix/element-tag
branch
from
25e5852 to
cbffa6a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #1696
Second attempt to return valid html tag to list items