Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Divider): render content inside #1701

Merged
merged 6 commits into from
Aug 23, 2024
Merged

feat(Divider): render content inside #1701

merged 6 commits into from
Aug 23, 2024

Conversation

blasdfaa
Copy link
Contributor

No description provided.

@blasdfaa blasdfaa requested a review from v4dyar4 as a code owner July 11, 2024 10:59
@blasdfaa
Copy link
Contributor Author

blasdfaa commented Jul 25, 2024 •
edited
Loading

@amje can i request more reviewers?

@v4dyar4
Copy link
Contributor

v4dyar4 commented Jul 26, 2024

Hi! Thx for the PR. I will do a review of PR very soon
@blasdfaa

@gravity-ui-bot
Copy link
Contributor

Preview is ready.

@gravity-ui-bot
Copy link
Contributor

Visual Tests Report is ready.

v4dyar4
v4dyar4 reviewed Aug 2, 2024
View reviewed changes
Copy link
Contributor

@v4dyar4 v4dyar4 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, please complete README.MD for GITHUB_BLOCK sections

Otherwise, everything is fine. Ty

src/components/Divider/__tests__/Divider.test.tsx Outdated Show resolved Hide resolved
@amje amje linked an issue Aug 8, 2024 that may be closed by this pull request
Render content inside Divider #1651
Closed
@blasdfaa blasdfaa requested a review from v4dyar4 August 15, 2024 13:59
@blasdfaa
Copy link
Contributor Author

@v4dyar4 ready

@blasdfaa
Copy link
Contributor Author

@v4dyar4 added

@blasdfaa blasdfaa requested a review from v4dyar4 August 16, 2024 16:54
@v4dyar4 v4dyar4 mentioned this pull request Aug 20, 2024
Open
@v4dyar4
Copy link
Contributor

v4dyar4 commented Aug 22, 2024

@blasdfaa Could you rebase branch and merge it?

@blasdfaa blasdfaa force-pushed the feat/divider-render-content branch from 49261b1 to 916a263 Compare August 22, 2024 12:13
@blasdfaa blasdfaa requested a review from v4dyar4 August 22, 2024 12:14
@blasdfaa
Copy link
Contributor Author

@blasdfaa Could you rebase branch and merge it?

approve please

@blasdfaa
Copy link
Contributor Author

@v4dyar4 I don't have the necessary access to merge

@v4dyar4 v4dyar4 merged commit 4d28d89 into gravity-ui:main Aug 23, 2024
6 checks passed
@gravity-ui-bot gravity-ui-bot mentioned this pull request Aug 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@v4dyar4 v4dyar4 v4dyar4 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Render content inside Divider
3 participants
@blasdfaa @v4dyar4 @gravity-ui-bot