Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Card): enable onClick event handler on selected card #1840

Merged
merged 7 commits into from
Sep 12, 2024
Merged

feat(Card): enable onClick event handler on selected card #1840

merged 7 commits into from
Sep 12, 2024

Conversation

DaryaLari
Copy link
Contributor

No description provided.

@gravity-ui-bot
Copy link
Contributor

Preview is ready.

@gravity-ui-bot
Copy link
Contributor

Visual Tests Report is ready.

@DaryaLari DaryaLari linked an issue Sep 6, 2024 that may be closed by this pull request
Card: ignores onClick prop with type=selection & selected props passed #1839
Closed
@DaryaLari DaryaLari marked this pull request as ready for review September 6, 2024 13:25
@DaryaLari DaryaLari requested a review from Lunory as a code owner September 6, 2024 13:25
@amje
Copy link
Contributor

amje commented Sep 6, 2024 •
edited
Loading

@DaryaLari Seems there is an issue with styles. Selected styles should not respect hover state

2024-09-06.16.32.30.mov

@DaryaLari DaryaLari requested a review from amje September 6, 2024 14:44
@DaryaLari
Copy link
Contributor Author

@DaryaLari Seems there is an issue with styles. Selected styles should not respect hover state

@amje Why do you consider it as an issue? In my universe, hover is an indication that you can interact with the element and it is not just a picture. Isn't it?..

@amje
Copy link
Contributor

amje commented Sep 11, 2024

@DaryaLari Seems there is an issue with styles. Selected styles should not respect hover state

@amje Why do you consider it as an issue? In my universe, hover is an indication that you can interact with the element and it is not just a picture. Isn't it?..

When selected state is not distinguished from not selected when it's hovered - it's bad. To know the currest state user must unhover first.

@DaryaLari DaryaLari merged commit a1678b6 into main Sep 12, 2024
6 checks passed
@DaryaLari DaryaLari deleted the fix-card-onclick branch September 12, 2024 12:56
@gravity-ui-bot gravity-ui-bot mentioned this pull request Sep 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lunory Lunory Lunory approved these changes

@amje amje amje approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Card: ignores onClick prop with type=selection & selected props passed
4 participants
@DaryaLari @gravity-ui-bot @amje @Lunory