feat: implement new Popover draft #1969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview is ready. |
|
Visual Tests Report is ready. |
ValeraS
reviewed
Dec 2, 2024
|
|
||
| return ( | ||
| <React.Fragment> | ||
| {React.cloneElement(child, {ref: anchorRef, ...getReferenceProps()})} |
There was a problem hiding this comment.
getReferenceProps overwrites anchor handlers, for example onClick, right?
There was a problem hiding this comment.
Yep, missed that one, fixed
ValeraS
reviewed
Dec 3, 2024
amje
force-pushed
the
popover-refactor
branch
from
3ded314 to
e15cc1e
Compare
ValeraS
approved these changes
Dec 4, 2024
amje
force-pushed
the
popover-refactor
branch
from
e15cc1e to
99e962a
Compare
amje
added a commit
that referenced
this pull request
Dec 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.