feat(Tabs): allow string for TabItem counter value #1989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EgorKluch
commented
Dec 12, 2024
src/components/Tabs/README.md
Outdated
| | Name | Description | Type | Default | | ||
| | :------- | ------------------------------ | :------------------------: | :-----: | | ||
| | id | Tab ID | `string` | | | ||
| | title | Tab title | `string` `React.ReactNode` | | |
There was a problem hiding this comment.
string already includes in ReactNode type
|
Preview is ready. |
|
Visual Tests Report is ready. |
korvin89
requested changes
Dec 12, 2024
src/components/Tabs/TabsItem.tsx
Outdated
| @@ -25,14 +25,14 @@ type ExtraProps = Omit< | |||
| export interface TabsItemProps { | |||
| id: string; | |||
| className?: string; | |||
| title: string | React.ReactNode; | |||
| title: React.ReactNode; | |||
There was a problem hiding this comment.
This is html title, it could have only type string
korvin89
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.