feat: migrate to new JSX transform #2006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
u4aew
requested review from
IsaevAlexandr,
ogonkov,
Raubzeug,
Arucard89,
korvin89,
Lunory,
kseniya57,
jhoncool,
SeqviriouM,
DakEnviy,
Marginy605,
amje and
ValeraS
as code owners
|
Preview is ready. |
|
Visual Tests Report is ready. |
u4aew
requested review from
NikitaCG,
sofiushko,
zamkovskaya,
mournfulCoroner,
Ruminat,
Vladeeg,
Estasie,
goshander,
d3m1d0v,
axtk and
v4dyar4
as code owners
ogonkov
reviewed
Dec 22, 2024
.eslintrc
Outdated
| @@ -32,7 +28,8 @@ | |||
| "import/consistent-type-specifier-style": ["error", "prefer-top-level"], | |||
| "@typescript-eslint/prefer-ts-expect-error": "error", | |||
| "@typescript-eslint/consistent-type-imports": ["error", {"prefer": "type-imports", "fixStyle": "separate-type-imports"}], | |||
| "complexity": "off" | |||
| "complexity": "off", | |||
| "react/react-in-jsx-scope": "off" | |||
There was a problem hiding this comment.
Guide also suggest react/jsx-uses-react
There was a problem hiding this comment.
We can simply extend plugin:react/jsx-runtime which does the job. No need to off the rules here.
amje
requested changes
Dec 24, 2024
| { | ||
| "selector": "ImportDeclaration[source.value='react'] :matches(ImportNamespaceSpecifier, ImportSpecifier)", | ||
| "message": "Please use import React from 'react' instead." | ||
| }, |
There was a problem hiding this comment.
Using React namespace is our codestyle. So import * as React from 'react' should be the only option.
To accomplish this, change the rule to:
{
"selector": "ImportDeclaration[source.value='react'] :matches(ImportDefaultSpecifier, ImportSpecifier)",
"message": "Please use `import * as React from 'react'` instead."
}
.babelrc
Outdated
| } | ||
| } | ||
| "sourceType": "unambiguous", | ||
| "presets": [ |
There was a problem hiding this comment.
Please keep current preset order
.eslintrc
Outdated
| @@ -32,7 +28,8 @@ | |||
| "import/consistent-type-specifier-style": ["error", "prefer-top-level"], | |||
| "@typescript-eslint/prefer-ts-expect-error": "error", | |||
| "@typescript-eslint/consistent-type-imports": ["error", {"prefer": "type-imports", "fixStyle": "separate-type-imports"}], | |||
| "complexity": "off" | |||
| "complexity": "off", | |||
| "react/react-in-jsx-scope": "off" | |||
There was a problem hiding this comment.
We can simply extend plugin:react/jsx-runtime which does the job. No need to off the rules here.
# Conflicts: # src/components/Alert/__tests__/Alert.visual.test.tsx
amje
approved these changes
Dec 25, 2024
|
@u4aew Thanks for contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added
react-jsxto tsconfig.json | tsconfig.test.json, updated rules in .eslintrc, updated presets in .babelrc and removedReactimports.docs
issue: #2003