Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Popover)!: replace legacy Popover with the new one #2031

Merged
merged 2 commits into from
Jan 9, 2025

Conversation

amje
Copy link
Contributor

@amje amje commented Dec 28, 2024

Summary of changes

  • Created legacy package entrypoint for deprecated and obsolete components, which can't be removed for a while.
  • Replaced Popover component with the component from Lab
  • Moved old Popover component to the legacy entrypoint

@gravity-ui-bot
Copy link
Contributor

Preview is ready.

@gravity-ui-bot
Copy link
Contributor

Visual Tests Report is ready.

trigger?: 'click';
openDelay?: number;
closeDelay?: number;
enableSafePolygon?: boolean;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you provide description for this option?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a note about it in Properties table in readme

@amje amje merged commit ccdf22e into next Jan 9, 2025
6 checks passed
@amje amje deleted the next-popover-replace branch January 9, 2025 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants