fix(Popup): anchor and replace floatingProps with floatingInteractions #2045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview is ready. |
|
Visual Tests Report is ready. |
amje
reviewed
Jan 15, 2025
src/components/Popover/Popover.tsx
Outdated
| floatingContext={context} | ||
| floatingRef={setFloatingElement} | ||
| floatingProps={getFloatingProps()} | ||
| floatingInteractions={interactions} | ||
| autoFocus | ||
| modalFocus | ||
| role="dialog" |
There was a problem hiding this comment.
I guess this not needed anymore
src/components/Popover/Popover.tsx
Outdated
Comment on lines
91
to
92
| outsidePress: true, | ||
| escapeKey: true, |
amje
approved these changes
Jan 15, 2025
amje
pushed a commit
that referenced
this pull request
Jan 16, 2025
amje
pushed a commit
that referenced
this pull request
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.