Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Slider): remove deprecated fields #2052

Open
wants to merge 5 commits into
base: next
Choose a base branch
from
Open

feat(Slider): remove deprecated fields #2052

wants to merge 5 commits into from

Conversation

Arucard89
Copy link
Contributor

@Arucard89 Arucard89 commented Jan 20, 2025 •
edited
Loading

Ticket: UXRFC-503

Breaking changes

Slider

  • removed deprecated field availableValues: set step to null and use marks, min and max props to specify available values to select instead
  • removed deprecated field marksCount: use marks instead
  • removed deprecated field hasTooltip: use tooltipDisplay instead
  • removed all this deprecated fields from parameters of prepareSliderInnerState

@Arucard89 Arucard89 requested review from amje and korvin89 January 20, 2025 11:26
@gravity-ui-bot
Copy link
Contributor

Preview is ready.

@gravity-ui-bot
Copy link
Contributor

Visual Tests Report is ready.

@korvin89
Copy link
Contributor

@Arucard89 could you provide description about deleted fields?

@Arucard89
Copy link
Contributor Author

@korvin89 , I wrote the description. Could you check, please, is it enough?

@korvin89
Copy link
Contributor

@korvin89 , I wrote the description. Could you check, please, is it enough?

@Arucard89 Yep. Check failed tests as well please

@Arucard89 Arucard89 force-pushed the slider-remove-deprecated-fields branch 2 times, most recently from b8d3300 to b8a390a Compare January 21, 2025 10:33
@Arucard89 Arucard89 force-pushed the slider-remove-deprecated-fields branch from b8a390a to bb10ac2 Compare January 21, 2025 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amje amje Awaiting requested review from amje

@korvin89 korvin89 Awaiting requested review from korvin89

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Arucard89 @gravity-ui-bot @korvin89