docs(Breadcrumbs): add readme #995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview is ready. |
Feverqwe
force-pushed
the
rndnm/DATAUI-1705
branch
from
e3ef64e to
18e85f6
Compare
Feverqwe
force-pushed
the
rndnm/DATAUI-1705
branch
from
18e85f6 to
11c1207
Compare
korvin89
reviewed
Sep 8, 2023
src/components/Breadcrumbs/README.md
Outdated
| import {Breadcrumbs} from '@gravity-ui/uikit'; | ||
| ``` | ||
|
|
||
| `Breadcrumbs` can collapse breadcrumbs that cause overflow. |
There was a problem hiding this comment.
I think we need a little bit more suitable description. Smth like this
|
|
||
| `Breadcrumbs` can collapse breadcrumbs that cause overflow. | ||
|
|
||
| ## Appearance |
There was a problem hiding this comment.
U can write about lastDisplayedItemsCount and firstDisplayedItemsCount either
There was a problem hiding this comment.
I think it extra info, I update description, if it not enough I can add info about it.
|
|
||
| <!--/GITHUB_BLOCK--> | ||
|
|
||
| ### Custom title |
There was a problem hiding this comment.
- Seems like a part of
BreadcrumbsItemitem menu, but not the part of the Appearance. - I think BreadcrumbsItem could have it own props table
Feverqwe
force-pushed
the
rndnm/DATAUI-1705
branch
2 times, most recently
from
1e1a0e3 to
c09d5bc
Compare
Feverqwe
force-pushed
the
rndnm/DATAUI-1705
branch
from
c09d5bc to
07734a7
Compare
korvin89
approved these changes
Sep 12, 2023
vrozaev
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.