Skip to content

gpnf-override-parent-merge-tag-on-submission.php: Fixed an issue with parent merge tags not updating Time value on entry edit. #905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

gpnf-override-parent-merge-tag-on-submission.php: Fixed an issue with parent merge tags not updating Time value on entry edit. #905

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
25ad5c0
`gpnf-override-parent-merge-tag-on-submission.php`: Fixed an issue wi…
saifsultanc Oct 11, 2024
d643b41
`gpnf-override-parent-merge-tag-on-submission.php`: Fixed an issue wi…
saifsultanc Oct 12, 2024
7c466de
`gpnf-override-parent-merge-tag-on-submission.php`: Fixed an issue wi…
saifsultanc Oct 16, 2024
3a11957
`gpnf-override-parent-merge-tag-on-submission.php`: Fixed an issue wi…
saifsultanc Oct 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion gp-nested-forms/gpnf-override-parent-merge-tag-on-submission.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,11 @@
}

foreach ( $inputs as $input ) {
$this->override_child_entry_input_value( $entry, $field, $child_form, $input['id'], rgar( $input, 'defaultValue' ) );
$default_value = ( $child_field->type != 'time' )

Check failure on line 98 in gp-nested-forms/gpnf-override-parent-merge-tag-on-submission.php

View workflow job for this annotation

GitHub Actions / PHPCS (Files Changed) 

Whitespace found at end of line
? rgar( $input, 'defaultValue' )

Check failure on line 99 in gp-nested-forms/gpnf-override-parent-merge-tag-on-submission.php

View workflow job for this annotation

GitHub Actions / PHPCS (Files Changed) 

Whitespace found at end of line
: preg_replace('/(\d+)\.\d+/', '$1', rgar( $child_field['inputs'][0], 'defaultValue' ) );

Check failure on line 100 in gp-nested-forms/gpnf-override-parent-merge-tag-on-submission.php

View workflow job for this annotation

GitHub Actions / PHPCS (Files Changed) 

Expected 1 spaces after opening parenthesis; 0 found

$this->override_child_entry_input_value( $entry, $field, $child_form, $input['id'], $default_value );
}
}
}
Expand Down
Loading