Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(newsletter, contact) strengthen types and remove generics #2447

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from
Open

feat(newsletter, contact) strengthen types and remove generics #2447

wants to merge 7 commits into from

Conversation

hanmindev
Copy link
Contributor

@hanmindev hanmindev commented May 23, 2023 •
edited by damienwebdev
Loading

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Fixes: N/A
Touches #1212

What is the new behavior?

Does this PR introduce a breaking change?

[x] Yes
[ ] No

Generics removed from:
contact

  • DaffContactServiceInterface
  • DaffContactSubmit
  • DaffContactRetry
  • DaffContactActions

newsletter

  • DaffNewsletterServiceInterface
  • DaffNewsletterSubscribe
  • DaffNewsletterRetry
  • DaffNewsletterActions
  • DaffNewsletterEffects

DaffNewsletterUnion removed. Replaced with more appropriate interfaces for each case

Other information

@hanmindev hanmindev requested a review from a team as a code owner May 23, 2023 18:02
@hanmindev hanmindev requested review from a team as code owners May 24, 2023 23:11
damienwebdev
damienwebdev requested changes Jun 1, 2023
View reviewed changes
libs/contact/driver/hubspot/src/config/contact-config.interface.ts Outdated Show resolved Hide resolved
libs/contact/driver/testing/src/contact.service.ts Show resolved Hide resolved
libs/contact/state/src/actions/contact.actions.ts Show resolved Hide resolved
libs/contact/state/src/actions/contact.actions.ts Show resolved Hide resolved
libs/contact/state/src/actions/contact.actions.ts Outdated Show resolved Hide resolved
libs/newsletter/driver/in-memory/src/backend/newsletter.service.ts Outdated Show resolved Hide resolved
libs/newsletter/driver/in-memory/src/drivers/newsletter.service.ts Outdated Show resolved Hide resolved
libs/newsletter/driver/in-memory/src/models/newsletter_storage.ts Outdated Show resolved Hide resolved
libs/newsletter/driver/src/interfaces/newsletter-service.interface.ts Show resolved Hide resolved
libs/newsletter/driver/testing/src/drivers/newsletter.service.ts Show resolved Hide resolved
@hanmindev hanmindev requested a review from damienwebdev June 8, 2023 19:26
@damienwebdev damienwebdev linked an issue Jan 3, 2024 that may be closed by this pull request
[OTHER] Tests for Hubspot Driver in @daffodil/contact and @daffodil/newsletter don't test their behaviors adequately #1212
Open
@damienwebdev damienwebdev added package: contact @daffodil/contact package: newsletter @daffodil/newsletter labels Jan 3, 2024
@griest024
feat(driver): strongly type hubspot forms service
a8a0436
@griest024
feat(contact)!: remove unecessary generics and improve tests
819f3e0 
BREAKING CHANGE: `DaffContactState` now uses `DaffOperationState`. Generics have been removed and the models have been narrowed.
@griest024
feat(newsletter)!: remove unecessary generics and improve tests
3cf57b4 
BREAKING CHANGE: `DaffNewsletterState` now uses `DaffOperationState`. Generics have been removed and the models have been narrowed.
@griest024
fix(demo): newsletter breaking changes
9c73b0c
@damienwebdev
Copy link
Member

@griest024 needs rebase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damienwebdev damienwebdev Awaiting requested review from damienwebdev

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
package: contact @daffodil/contact package: newsletter @daffodil/newsletter
Projects
None yet
Milestone
No milestone
3 participants
@hanmindev @damienwebdev @griest024