Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(daffio): update marketing and docs sidebars, add packages sidebar #2716

Closed
wants to merge 2 commits into from

Conversation

xelaint
Copy link
Member

@xelaint xelaint commented Jan 12, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Part of: #2682

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@xelaint
Copy link
Member Author

xelaint commented Jan 12, 2024

@griest024 this PR covers a few different things, but they're kind of intertwined and hard to split up. Lmk if the commits are confusing. I have a few questions and requests regarding named views and dynamic sidebar:

  1. Header and footer is not always used. How to hide the containers if they’re not used?
  2. Some sidebars may only have header/footers when it’s in a mobile view or if sidebar goes from side-fixed to over/under. How can I change visibility depending on these conditions?
  3. Sidebar content should switch depending on which activator is pressed/clicked on. The top level hamburger menu opens the docs sidebar, but the button within the doc viewer that says packages menu should open the packages list sidebar.

@xelaint xelaint added the package: daff.io @daffodil/daff.io label Jan 16, 2024
@xelaint xelaint added this to the Daffodil v1.0 milestone Jan 16, 2024
@xelaint xelaint changed the title Sidebar Updates feat(daffio): update marketing and docs sidebars, add packages sidebar Jan 16, 2024
@xelaint xelaint force-pushed the packages-page-update branch 2 times, most recently from 6224277 to 1d09315 Compare January 16, 2024 15:40
@xelaint xelaint added status: wip This PR is WIP. It should be marked as a draft. help wanted Extra attention is needed for this PR or issue labels Jan 16, 2024
@xelaint xelaint force-pushed the packages-page-update branch from 0ce6648 to 54cd9f3 Compare January 17, 2024 14:45
@xelaint
Copy link
Member Author

xelaint commented Jan 17, 2024

Closed in favor of #2725

@xelaint xelaint closed this Jan 17, 2024
@xelaint xelaint deleted the packages-page-update branch March 13, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed for this PR or issue package: daff.io @daffodil/daff.io status: wip This PR is WIP. It should be marked as a draft.
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants