-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(design)!: update breadcrumb active state implementation #3523
base: develop
Are you sure you want to change the base?
Conversation
setActive(value: boolean) { | ||
this._active = value; | ||
if (value) { | ||
this.renderer.addClass(this.elementRef.nativeElement, 'active'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it makes more sense to keep the original implementation and just remove the original @Input
. I think access to the renderer should be used sparingly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated
@xelaint can you add an example with an |
@damienwebdev Added the example. The implementation in next.daff.io/docs also uses |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Enduser is allowed to use the
active
property, but it should just default to the last breadcrumb item.Fixes: #3514
What is the new behavior?
The active state is automatically set to the last breadcrumb item in a list of breadcrumbs.
Does this PR introduce a breaking change?
BREAKING CHANGE: T
active
property is no longer available to use. The last breadcrumb item will automatically be set to the active state.Other information