Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(design): add prefix/suffix directives to @daffodil/design #527

Merged
merged 2 commits into from
Dec 20, 2019

Conversation

xelaint
Copy link
Member

@xelaint xelaint commented Dec 19, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Fixes: #472
Part of: #416

What is the new behavior?

Add Prefix/Suffix directive to easily add and style icons used in components.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@xelaint xelaint added the package: design @daffodil/design label Dec 19, 2019
@xelaint xelaint requested a review from a team as a code owner December 19, 2019 10:41
@xelaint xelaint self-assigned this Dec 19, 2019
@xelaint xelaint changed the title Prefix suffix feat(design): add prefix/suffix directives to core Dec 19, 2019
@xelaint xelaint assigned damienwebdev and unassigned xelaint Dec 19, 2019
@xelaint xelaint changed the title feat(design): add prefix/suffix directives to core feat(design): add prefix/suffix directives to @daffodil/design core Dec 19, 2019
@xelaint xelaint changed the title feat(design): add prefix/suffix directives to @daffodil/design core feat(design): add prefix/suffix directives to @daffodil/design Dec 19, 2019
Copy link
Member

@damienwebdev damienwebdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be split into two PRs since it can be done backward compatibly.

@xelaint
Copy link
Member Author

xelaint commented Dec 20, 2019

This should be split into two PRs since it can be done backward compatibly.

Do I need to split it if the commits are separated correctly?

@damienwebdev
Copy link
Member

I think it's worthy of two PRs. Each of these are unique enough.

Copy link
Member

@damienwebdev damienwebdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, some minor comments here and there.

@damienwebdev damienwebdev merged commit 87f909c into develop Dec 20, 2019
@damienwebdev damienwebdev deleted the prefix-suffix branch December 27, 2019 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: design @daffodil/design
Projects
Development

Successfully merging this pull request may close these issues.

[FEAT] Prefix/Suffix Directives in @daffodil/design
2 participants