-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(design): add prefix/suffix directives to @daffodil/design #527
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be split into two PRs since it can be done backward compatibly.
Do I need to split it if the commits are separated correctly? |
I think it's worthy of two PRs. Each of these are unique enough. |
477cc26
to
d954c07
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, some minor comments here and there.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Fixes: #472
Part of: #416
What is the new behavior?
Add Prefix/Suffix directive to easily add and style icons used in components.
Does this PR introduce a breaking change?
Other information