Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(design): add form label directive #529

Merged
merged 1 commit into from
Dec 23, 2019
Merged

feat(design): add form label directive #529

merged 1 commit into from
Dec 23, 2019

Conversation

xelaint
Copy link
Member

@xelaint xelaint commented Dec 21, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

No centralized way of styling form labels.

Part of: #416

What is the new behavior?

Add a daffFormLabel directive to make css code for styling labels more cohesive.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@xelaint xelaint added the package: design @daffodil/design label Dec 21, 2019
@xelaint xelaint requested a review from a team as a code owner December 21, 2019 07:39
Copy link
Member

@damienwebdev damienwebdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@damienwebdev damienwebdev merged commit a23b9ee into develop Dec 23, 2019
@damienwebdev damienwebdev deleted the form-label branch December 27, 2019 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: design @daffodil/design
Projects
Development

Successfully merging this pull request may close these issues.

2 participants