Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(design): add radio and radio-set component #565

Closed
wants to merge 5 commits into from

Conversation

xelaint
Copy link
Member

@xelaint xelaint commented Jan 16, 2020

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

No radio or radio-set component.

Part of: #416

What is the new behavior?

@daffodil/design now has radio and radio-set components to use in forms.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@xelaint xelaint added the package: design @daffodil/design label Jan 16, 2020
@xelaint xelaint requested review from a team as code owners January 16, 2020 07:16
@codecov
Copy link

codecov bot commented Feb 10, 2020

Codecov Report

Merging #565 into develop will decrease coverage by 0.30%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #565      +/-   ##
===========================================
- Coverage    96.93%   96.63%   -0.31%     
===========================================
  Files          334      336       +2     
  Lines         1957     2019      +62     
  Branches        99      103       +4     
===========================================
+ Hits          1897     1951      +54     
- Misses          51       58       +7     
- Partials         9       10       +1     
Impacted Files Coverage Δ
...ibs/design/src/atoms/form/radio/radio.component.ts 81.48% <0.00%> (ø)
...gn/src/atoms/form/radio-set/radio-set.component.ts 91.42% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a684f82...656e192. Read the comment docs.

@xelaint xelaint closed this Mar 25, 2020
@damienwebdev damienwebdev deleted the radio-component branch April 16, 2020 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: design @daffodil/design
Projects
Development

Successfully merging this pull request may close these issues.

2 participants