feat(design): created DaffCheckbox and DaffCheckboxSet components #864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xelaint
requested changes
Apr 30, 2020
libs/design/src/atoms/form/checkbox-set/checkbox-set.component.ts
Outdated
Show resolved
Hide resolved
xelaint
previously requested changes
May 4, 2020
Nolan-Arnold
force-pushed
the
daff-checkbox
branch
from
13caa24 to
d19685b
Compare
|
lgtm but wait for @damienwebdev to review |
damienwebdev
requested changes
May 22, 2020
There was a problem hiding this comment.
@Nolan-Arnold can you provide some examples of validation of the values of the FormArray?
Additionally, it looks like the resultant value of the FormArray contains a lot of empty strings. We should strictly define this behavior to either false, '', null, or undefined.
libs/design/src/atoms/form/checkbox-set/checkbox-set.component.spec.ts
Outdated
Show resolved
Hide resolved
libs/design/src/atoms/form/checkbox-set/checkbox-set.component.ts
Outdated
Show resolved
Hide resolved
Nolan-Arnold
force-pushed
the
daff-checkbox
branch
from
d19685b to
a15276d
Compare
damienwebdev
requested changes
May 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Part of: #416
What is the new behavior?
Does this PR introduce a breaking change?
Other information