Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] AI-recommended Expectations #10913

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from
Open

[DOCS] AI-recommended Expectations #10913

wants to merge 8 commits into from

Conversation

klavavej
Copy link
Contributor

@klavavej klavavej commented Feb 4, 2025

Resolves https://greatexpectations.atlassian.net/browse/DOC-1041 according to the plan linked in that issue

  • Description of PR changes above includes a link to an existing GitHub issue
  • PR title is prefixed with one of: [BUGFIX], [FEATURE], [DOCS], [MAINTENANCE], [CONTRIB]
  • Code is linted - run invoke lint (uses ruff format + ruff check)
  • Appropriate tests and docs have been updated

For more information about contributing, visit our community resources.

After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!

Copy link

netlify bot commented Feb 4, 2025

Deploy Preview for niobium-lead-7998 ready!

Name Link
🔨 Latest commit 012a52c
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/67a3ed08f77519000822ff6f
😎 Deploy Preview https://deploy-preview-10913.docs.greatexpectations.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.77%. Comparing base (3c0f956) to head (012a52c).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #10913   +/-   ##
========================================
  Coverage    80.77%   80.77%           
========================================
  Files          465      465           
  Lines        40614    40614           
========================================
  Hits         32805    32805           
  Misses        7809     7809           
Flag Coverage Δ
3.10 70.09% <ø> (ø)
3.10 athena or openpyxl or pyarrow or project or sqlite or aws_creds 56.52% <ø> (?)
3.10 aws_deps 46.41% <ø> (?)
3.10 big 54.91% <ø> (?)
3.10 bigquery 48.67% <ø> (?)
3.10 clickhouse 43.30% <ø> (?)
3.10 databricks 50.45% <ø> (?)
3.10 filesystem 62.87% <ø> (?)
3.10 mssql 51.45% <ø> (?)
3.10 mysql 51.83% <ø> (?)
3.10 postgresql 54.47% <ø> (?)
3.10 snowflake 51.23% <ø> (?)
3.10 spark 57.80% <ø> (?)
3.10 spark_connect 46.74% <ø> (?)
3.10 trino 52.38% <ø> (?)
3.11 70.07% <ø> (ø)
3.11 athena or openpyxl or pyarrow or project or sqlite or aws_creds 56.52% <ø> (?)
3.11 aws_deps 46.41% <ø> (?)
3.11 big 54.91% <ø> (?)
3.11 bigquery 48.67% <ø> (?)
3.11 clickhouse 43.30% <ø> (?)
3.11 databricks 50.45% <ø> (?)
3.11 filesystem 62.87% <ø> (?)
3.11 mssql 51.45% <ø> (?)
3.11 mysql 51.83% <ø> (?)
3.11 postgresql 54.47% <ø> (?)
3.11 snowflake 51.23% <ø> (?)
3.11 spark 57.80% <ø> (?)
3.11 spark_connect 46.74% <ø> (?)
3.11 trino 52.38% <ø> (?)
3.12 70.07% <ø> (-0.02%) ⬇️
3.12 athena or openpyxl or pyarrow or project or sqlite or aws_creds 56.52% <ø> (ø)
3.12 aws_deps 46.41% <ø> (ø)
3.12 big 54.91% <ø> (ø)
3.12 bigquery 48.67% <ø> (ø)
3.12 databricks 50.45% <ø> (ø)
3.12 filesystem 62.87% <ø> (ø)
3.12 mssql 51.46% <ø> (ø)
3.12 mysql 51.83% <ø> (ø)
3.12 postgresql 54.48% <ø> (ø)
3.12 snowflake 51.23% <ø> (ø)
3.12 spark 57.81% <ø> (ø)
3.12 spark_connect 46.74% <ø> (ø)
3.12 trino 52.38% <ø> (ø)
3.9 70.10% <ø> (ø)
3.9 athena or openpyxl or pyarrow or project or sqlite or aws_creds 56.52% <ø> (ø)
3.9 aws_deps 46.43% <ø> (ø)
3.9 big 54.92% <ø> (ø)
3.9 bigquery 48.66% <ø> (ø)
3.9 clickhouse 43.32% <ø> (ø)
3.9 databricks 50.45% <ø> (-0.01%) ⬇️
3.9 filesystem 62.87% <ø> (ø)
3.9 mssql 51.44% <ø> (ø)
3.9 mysql 51.81% <ø> (ø)
3.9 postgresql 54.46% <ø> (ø)
3.9 snowflake 51.23% <ø> (ø)
3.9 spark 57.77% <ø> (ø)
3.9 spark_connect 46.76% <ø> (ø)
3.9 trino 52.37% <ø> (ø)
cloud 0.00% <ø> (ø)
docs-basic 54.00% <ø> (ø)
docs-creds-needed 52.88% <ø> (ø)
docs-spark 52.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@klavavej klavavej marked this pull request as ready for review February 4, 2025 16:50
@klavavej
Copy link
Contributor Author

klavavej commented Feb 5, 2025

@@ -138,6 +138,21 @@ To clear the Expectation condition, click the clear button located on the right-
When you [create a new Data Asset](/cloud/data_assets/manage_data_assets.md#add-a-data-asset-from-an-existing-data-source), you can choose to automatically generate Expectations that detect column changes in that Data Asset.
:::

## Generate Expectations with ExpectAI (BETA)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: is there a way to make the beta tag a pill in markdown rather than plain text?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the current functionality of the docs site, no. I called this out of scope in my docs plan because we'd need to add a new custom docusaurus component to enable this. I can file an issue to get such a component for future use

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to know, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants