Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated nodejs version to LTS to avoid compatibility issues with npm #80

Merged
merged 1 commit into from
Jan 14, 2023

Conversation

sravantit25
Copy link
Contributor

Fix for the below issue:
#79

Summary:
great_expectations_action build docker image is failing with incompatible Node.js version

@sravantit25
Copy link
Contributor Author

@cla-bot check

Copy link

@AFineDayFor AFineDayFor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Howdy, the team raises a very strong point, which is can we just pin a version of node rather than have a remote script.

@sravantit25
Copy link
Contributor Author

Howdy, the team raises a very strong point, which is can we just pin a version of node rather than have a remote script.

The script points to the Long Term Supported version (LTS) which will automatically get upgraded to the next supported version when this version gets outdated. The link always remains updated.
But if this is really a concern, I will update it to a specific version. Do let me know.

@sravantit25
Copy link
Contributor Author

Hello! Can you let me know your thoughts on the above PR? I can make the change if required, submit for review and close it!
Thank you!

@jcampbell
Copy link
Contributor

I'm going to merge this as-is, but also mark this action as explicitly no longer maintained. With changes to the underlying GX that have happened in the past couple of years, we recommend using checkpoints directly now!

@jcampbell jcampbell merged commit a9b9127 into great-expectations:main Jan 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants