Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINTENANCE] Remaining integration tests around GXValidateCheckpointOperator #11

Merged

Conversation

tyler-hoffman
Copy link
Contributor

@tyler-hoffman tyler-hoffman commented Jan 9, 2025

Adds remaining integration tests around GXValidateCheckpointOperator.

The approach

  • 1 test per context type
  • 1 test per category of data source (sql, file system, data frame)

New stuff

  • Light-weight fixture for writing csv files
  • Splits apart the checkpoint configuration fixture so that one fixture creates the checkpoint, and one knows about cleaning it up, since that's only relevant to cloud
  • More comments

Where this strays from the light
CORE 728 says "Cloud tests should ensure that the validation result can be retrieved from the cloud backend.", but a) our API for that doesn't work, and b) that's testing gx cloud itself, not our interactions with it via the operator, so I think it's fine and reasonable to skip that.

Copy link
Member

@joshua-stauffer joshua-stauffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, this looks great, and i agree with your assessment that we don't need to actually pull results from cloud. I would like to make sure we're giving the user a path to retrieve them. Could we assert (in this PR or in a followup) that the user receives the results_url in the operator return value?

@tyler-hoffman
Copy link
Contributor Author

thanks, this looks great, and i agree with your assessment that we don't need to actually pull results from cloud. I would like to make sure we're giving the user a path to retrieve them. Could we assert (in this PR or in a followup) that the user receives the results_url in the operator return value?

yeah good call. ff24119 adds a rough assertion on this.

@tyler-hoffman tyler-hoffman merged commit d89baa1 into main Jan 9, 2025
7 checks passed
@tyler-hoffman tyler-hoffman deleted the m/CORE-728/validate-checkpoint-operator-remaining-itests branch January 9, 2025 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants