-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Amaranth 0.5 #278
base: main
Are you sure you want to change the base?
Conversation
20f58e7
to
0ac7d28
Compare
I think this is ready for review now. I decided to drop the I also decided to skip porting away from Otherwise it's all fairly simple changes from the list here: https://amaranth-lang.org/docs/amaranth/latest/changes.html#migrating-from-version-0-4 |
luna/gateware/debug/ila.py
Outdated
@@ -77,7 +78,7 @@ def __init__(self, *, signals, sample_depth, domain="sync", sample_rate=60e6, sa | |||
# | |||
# Create a backing store for our samples. | |||
# | |||
self.mem = Memory(width=self.sample_width, depth=sample_depth, name="ila_buffer") | |||
self.mem = Memory(shape=Shape(self.sample_width), depth=sample_depth, init=[]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not necessary to explicitly construct a Shape
here, any shape-like can be used, and since that includes integers, you can simply just pass shape=self.sample_width
. shape
is effectively a superset of the old width
argument.
This goes for the other Memory
instances in this commit as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed, thanks!
Work-in-progress on updating to Amaranth 0.5:
reset=
withinit=
Pin
Update tests to remove uses ofadd_sync_process