Don't assume strings are mutable #56
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @chocolateboy , can you write a test for this? |
|
I've tested it manually. You can test it automatically by adding: # frozen_string_literal: trueto the start of every ruby file (which is recommended anyway). That way all specs test it. |
|
Sorry, I don't have a ruby environment anymore and really can't merge anything that doesn't have a test. Maybe one of the other maintainers of this repo can take a look. I don't think there are any other maintainers that are active for this repo :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid a
FrozenErrorwhen strings are frozen globally, e.g. via--enable=frozen-string-literal.