-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/add stratified tes #148
Conversation
Co-authored-by: Sabine Haas <[email protected]>
No, I'm happy you have comments. Your review has helped me a lot, thank you! 🙏
Thanks for finding this! Added with commit 6a2e745. |
…-project/pvcompare into feature/add_stratified_TES
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made it through the tests now! Only a few changes then you can merge :)
Feature/restiction tes temp
Co-authored-by: Sabine Haas <[email protected]>
…-project/pvcompare into feature/add_stratified_TES
With this PR the stratified thermal energy storage is added to the sector coupling model.
At present, in the mvs the oemof.solph component
GenericStorage
is defined with the following input parameters (cf. D1_model_components.py):To implement the oemof.thermal stratified thermal storage, two further input parameter would be needed (cf. example 01_operation_generic_storage.py):
They are used to take into account temperature dependent losses of the
GenericStorage
.The procedure within this PR is as follows:
stratified_thermal_storage.py
nominal_storage_capacity
andloss_rate
intostorage_02.csv
(installedCap
andefficiency
)fixed_losses_relative
andfixed_losses_absolute
)The following steps were realized, as well (if applies):
black . --exclude docs/
)Please mark above checkboxes as following:
❌ Check not applicable to this PR
For more information on how to contribute check the CONTRIBUTING.md.