Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ec36 avoid autoplay #40

Merged
merged 5 commits into from
Jan 27, 2025
Merged

Ec36 avoid autoplay #40

merged 5 commits into from
Jan 27, 2025

Conversation

chihebtalan
Copy link
Contributor

No description provided.

@chihebtalan chihebtalan force-pushed the ec36-avoid-autoplay branch from 9e1fab7 to 4f1705e Compare May 30, 2024 12:42
@chihebtalan @dianecdr
Add rule "Avoid autoplay"
5a3b699 
Co-authored-by: Diane Cordier <[email protected]>
@chihebtalan chihebtalan force-pushed the ec36-avoid-autoplay branch from 4f1705e to 5a3b699 Compare May 30, 2024 12:43
chihebtalan and others added 2 commits May 30, 2024 15:06
@chihebtalan @dianecdr
Add rule "Avoid autoplay"
229c8e2 
Co-authored-by: Diane Cordier <[email protected]>
@chihebtalan @dianecdr
Add rule "Avoid autoplay"
752d60c 
Co-authored-by: Diane Cordier <[email protected]>
utarwyn
utarwyn requested changes May 31, 2024
View reviewed changes
Copy link
Member

@utarwyn utarwyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this awesome work! 💪 I have done some reviews..

CHANGELOG.md Outdated Show resolved Hide resolved
eslint-plugin/docs/rules/avoid-autoplay.md Show resolved Hide resolved
eslint-plugin/lib/rules/avoid-autoplay.js Outdated Show resolved Hide resolved
eslint-plugin/tests/lib/rules/avoid-autoplay.js Outdated Show resolved Hide resolved
sonar-plugin/src/main/java/io/ecocode/javascript/CheckList.java Outdated Show resolved Hide resolved
sonar-plugin/src/main/resources/io/ecocode/profiles/ecocode_typescript_profile.json Outdated Show resolved Hide resolved
sonar-plugin/src/main/resources/io/ecocode/rules/javascript/EC36.html Outdated Show resolved Hide resolved
sonar-plugin/src/main/resources/io/ecocode/rules/javascript/EC36.json Outdated Show resolved Hide resolved
@utarwyn utarwyn added 🗃️ rule Impacts a rule 🏆 challenge 🏆 Work done during the ecoCode Challenge labels May 31, 2024
@utarwyn utarwyn mentioned this pull request Jan 22, 2025
Merged
@utarwyn utarwyn force-pushed the ec36-avoid-autoplay branch from 36e50f1 to 593f1f1 Compare January 27, 2025 21:33
@utarwyn utarwyn self-requested a review January 27, 2025 21:34
@utarwyn utarwyn merged commit a14c77c into green-code-initiative:main Jan 27, 2025
3 checks passed
@utarwyn utarwyn linked an issue Feb 3, 2025 that may be closed by this pull request
Implement rule "Avoid autoplay for videos and audio content" #34
Closed
@utarwyn utarwyn mentioned this pull request Feb 3, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@utarwyn utarwyn utarwyn approved these changes

Assignees

@chihebtalan chihebtalan

Labels
🏆 challenge 🏆 Work done during the ecoCode Challenge 🗃️ rule Impacts a rule
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement rule "Avoid autoplay for videos and audio content"
2 participants
@chihebtalan @utarwyn