Fix: Override default notification-channel #232
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conventional Commits Report
🚀 Conventional commits found. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #232 +/- ##
=======================================
Coverage 99.34% 99.34%
=======================================
Files 7 7
Lines 455 455
=======================================
Hits 452 452
Misses 3 3 ☔ View full report in Codecov by Sentry. |
|
Even if this includes "feed" in the repository, the feed-sync script is not a feed component, thus 2ndGen deployment should be feasible! |
auto-merge was automatically disabled
October 6, 2024 07:30
Pull request was closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Override default notification-channel
Why
greenbone-feed-sync counts as a feed repo, so it should notify in a different channel.
References
https://jira.greenbone.net/browse/DEVOPS-1254