Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show status of "Use workaround for default certificate" of alerts correctly. #3802

Merged
merged 1 commit into from
Jul 13, 2023

Conversation

jhelmold
Copy link
Member

@jhelmold jhelmold commented Jul 6, 2023

What

Small correction to display the status of "Use workaround for default certificate" of alerts
(method "TippingPoint SMS") correctly.

Why

This is a bug-fix.

References

GEA-230

Checklist

Tested manually on my local development system.

  • Tests

@github-actions
Copy link

github-actions bot commented Jul 6, 2023

Conventional Commits Report

😢 No conventional commits found.

👉 Learn more about the conventional commits usage at Greenbone.

@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Merging #3802 (47b6501) into main (0008815) will not change coverage.
The diff coverage is 0.00%.

❗ Current head 47b6501 differs from pull request most recent head cc76b05. Consider uploading reports for the commit cc76b05 to get more accurate results

@@           Coverage Diff           @@
##             main    #3802   +/-   ##
=======================================
  Coverage   60.08%   60.08%           
=======================================
  Files        1023     1023           
  Lines       25145    25145           
  Branches     7429     7429           
=======================================
  Hits        15109    15109           
  Misses       9094     9094           
  Partials      942      942           
Impacted Files Coverage Δ
src/web/pages/alerts/method.js 17.05% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jhelmold jhelmold marked this pull request as ready for review July 6, 2023 13:20
@jhelmold jhelmold requested a review from a team as a code owner July 6, 2023 13:20
@jhelmold jhelmold enabled auto-merge July 6, 2023 15:01
Small correction to display the status of "Use workaround for
default certificate" correctly.
@timopollmeier timopollmeier force-pushed the GEA-230_TippingPoint_SMS_Alert_fails_to_save_status branch from 47b6501 to cc76b05 Compare July 13, 2023 17:08
@jhelmold jhelmold merged commit 85532fa into main Jul 13, 2023
8 checks passed
@jhelmold jhelmold deleted the GEA-230_TippingPoint_SMS_Alert_fails_to_save_status branch July 13, 2023 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants