Fix release activated workflow via labels #3817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The if clauses of the dependent jobs haven't been adjusted for the new release process and its different labels. Therefore using a release label didn't run the jobs. This change removes the if statements from the dependent jobs completely because the first job will check them and otherwise the dependent jobs wont run at all.
Conventional Commits Report
🚀 Conventional commits found. |
Codecov Report
@@ Coverage Diff @@
## main #3817 +/- ##
=======================================
Coverage 60.08% 60.08%
=======================================
Files 1023 1023
Lines 25145 25145
Branches 7429 7429
=======================================
Hits 15109 15109
Misses 9094 9094
Partials 942 942
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
timopollmeier
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fix release activated workflow via labels
Why
The if clauses of the dependent jobs haven't been adjusted for the new release process and its different labels. Therefore using a release label didn't run the jobs. This change removes the if statements from the dependent jobs completely because the first job will check them and otherwise the dependent jobs wont run at all.
References
#3816