Change: Show subject first in TLS certificate list, show both DNs in details #3820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conventional Commits Report
🚀 Conventional commits found. |
3 tasks
timopollmeier
force-pushed
the
use-subject-dn-for-tls-certs
branch
from
e06dc65
to
c33654d
Compare
…details Instead of the Issuer DN the TLS certificate list now shows the Subject DN in the first column. Both subject and issuer DN are added to the details. This change was made because the subject DN is the more useful information to users.
timopollmeier
force-pushed
the
use-subject-dn-for-tls-certs
branch
from
c33654d
to
70d7202
Compare
Codecov Report
@@ Coverage Diff @@
## main #3820 +/- ##
=======================================
Coverage 60.08% 60.09%
=======================================
Files 1023 1023
Lines 25145 25148 +3
Branches 7429 7433 +4
=======================================
+ Hits 15109 15112 +3
Misses 9094 9094
Partials 942 942
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jhelmold
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Instead of the Issuer DN the TLS certificate list now shows the Subject DN in the first column. Both subject and issuer DN are added to the details.
Why
This change was made because the subject DN is the more useful information to users.
References
GEA-202
Closes #2847
Based on changes proposed in #3023 by @Virsacer