Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove: Remove unused license management page #3839

Merged
merged 1 commit into from
Aug 17, 2023

Conversation

timopollmeier
Copy link
Member

What

The unused license management page and corresponding dialog are removed. Notifications about the license are still kept as a template for new notifications but will be removed later.

Why

The license page was removed because it caused confusion for users expecting an information page instead of a warning about a disabled feature when they entered the URL manually.

References

GEA-177

The unused license management page and corresponding dialog are removed.
Notifications about the license are still kept as a template for new
notifications but will be removed later.

The license page was removed because it caused confusion for users
expecting an information page instead of a warning about a disabled
feature when they entered the URL manually.
@github-actions
Copy link

Conventional Commits Report

Type Number
Removed 1

🚀 Conventional commits found.

@timopollmeier timopollmeier marked this pull request as ready for review August 16, 2023 12:38
@timopollmeier timopollmeier requested a review from a team as a code owner August 16, 2023 12:38
@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Merging #3839 (308a940) into main (ac0ac87) will decrease coverage by 0.19%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3839      +/-   ##
==========================================
- Coverage   60.09%   59.91%   -0.19%     
==========================================
  Files        1023     1021       -2     
  Lines       25154    25082      -72     
  Branches     7436     7417      -19     
==========================================
- Hits        15116    15027      -89     
- Misses       9096     9107      +11     
- Partials      942      948       +6     
Files Changed Coverage Δ
src/web/components/bar/menubar.js 6.86% <ø> (+0.13%) ⬆️
src/web/routes.js 83.33% <ø> (ø)

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@timopollmeier timopollmeier merged commit 5038602 into main Aug 17, 2023
9 of 10 checks passed
@timopollmeier timopollmeier deleted the remove-license-page branch August 17, 2023 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants