Add a BulkTags component for handling tagging of entities #4070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. OpenSSF Scorecard
Scanned Manifest Files |
Conventional Commits Report
🚀 Conventional commits found. |
daniele-mng
reviewed
Jun 17, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4070 +/- ##
==========================================
+ Coverage 72.25% 72.44% +0.19%
==========================================
Files 1064 1066 +2
Lines 121658 121953 +295
Branches 6002 6047 +45
==========================================
+ Hits 87899 88351 +452
+ Misses 33728 33571 -157
Partials 31 31 ☔ View full report in Codecov by Sentry. |
The BulkTags component provides dialogs and functions for tagging several entities with an existing or new tag.
The gmp object is not part of saving a tag. Therefore it shouldn't be put into the state of the TagDialog and passed to the onSave handler.
Allow to show errors in the TagsDialog. This may be necessary for example if a new tag can't be created.
daniele-mng
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add a BulkTags component for handling tagging of entities
Why
The BulkTags component provides dialogs and functions for tagging several
entities with an existing or new tag.
References
HOC less entities pages
Checklist