Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve empty trashcan btn opensight #4165

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

daniele-mng
Copy link
Contributor

What

  • Added confirmation dialog for emptying out the trashcan with a small delay.

Why

  • User have no feedback if emptying out the trashcan was successful.

References

GEA-664

Checklist

  • Tests

@daniele-mng daniele-mng requested a review from a team as a code owner September 26, 2024 06:11
Copy link

github-actions bot commented Sep 26, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA 4d67f0a.
Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

Copy link

Conventional Commits Report

Type Number
Changed 1

🚀 Conventional commits found.

Copy link

codecov bot commented Sep 26, 2024

Codecov Report

Attention: Patch coverage is 98.36066% with 1 line in your changes missing coverage. Please review.

Project coverage is 64.34%. Comparing base (40e19d4) to head (4d67f0a).
Report is 2 commits behind head on opensight-ui.

Files with missing lines Patch % Lines
src/web/pages/extras/trashcanpage.jsx 98.14% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           opensight-ui    #4165      +/-   ##
================================================
+ Coverage         63.34%   64.34%   +1.00%     
================================================
  Files              1107     1107              
  Lines            103441   103485      +44     
  Branches           6421     6457      +36     
================================================
+ Hits              65522    66592    +1070     
+ Misses            37753    36753    -1000     
+ Partials            166      140      -26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@daniele-mng daniele-mng changed the title change: add confirmation dialog for trashcan Improve empty trashcan btn opensight Sep 27, 2024
@daniele-mng daniele-mng force-pushed the improve-empty-trashcan-btn-opensight branch from 8c93517 to 4d67f0a Compare September 27, 2024 08:34
@daniele-mng daniele-mng merged commit 4664dea into opensight-ui Sep 27, 2024
10 checks passed
@daniele-mng daniele-mng deleted the improve-empty-trashcan-btn-opensight branch September 27, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants